Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker] Fix unloadNamespaceBundlesGracefully can be stuck with extensible load manager (#23349) #23496

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[fix][broker] Fix unloadNamespaceBundlesGracefully can be stuck with extensible load manager (#23349) #23496

merged 2 commits into from
Oct 23, 2024

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Oct 22, 2024 •
edited
Loading

(cherry picked from commit e91574a)

I need to export some of the changes in #23301 to resolve conflicts.

fork-test: heesung-sn#83

@github-actions GitHub Actions
Copy link

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@BewareMyPower BewareMyPower added doc-not-needed Your PR changes do not impact docs ready-to-test labels Oct 23, 2024
@heesung-sn
Copy link
Contributor Author

heesung-sn commented Oct 23, 2024 •
edited
Loading

I added this change in this PR, 3b9e857 to handle ClusterMigrationTest.testClusterMigrationWithReplicationBacklog failure.

Regarding ClusterMigrationTest.testClusterMigrationWithReplicationBacklog failure, the root cause is that after the broker is disabled, the assignment operation couldn't complete, and its lookup timed out. To handle this, we don't allow assignment when the broker is disabled.

However, this test passes in the master branch now without this change.

@BewareMyPower BewareMyPower merged commit d42dacb into apache:branch-3.3 Oct 23, 2024
50 checks passed
@heesung-sn heesung-sn deleted the branch-3.3-cherry-pick branch October 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@lhotari lhotari Awaiting requested review from lhotari

Assignees
No one assigned
Labels
cherry-picked/branch-3.3 doc-label-missing doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heesung-sn @BewareMyPower @lhotari